Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] LDAP Enterprise improvement (+ minor link fix) #8392

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

Isan-Rivkin
Copy link
Contributor

@Isan-Rivkin Isan-Rivkin commented Nov 21, 2024

Closes #8393

Will merge once have single approve AND no other review comments

  1. Added guide for LDAP
  2. Broken link fix (unrelated in external principals)

Copy link

github-actions bot commented Nov 21, 2024

♻️ PR Preview feb147e has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@Isan-Rivkin Isan-Rivkin added the exclude-changelog PR description should not be included in next release changelog label Nov 21, 2024
@Isan-Rivkin Isan-Rivkin changed the title LDAP Enterprise docs improvement (+ minor link fix) [Docs] LDAP Enterprise improvement (+ minor link fix) Nov 21, 2024
Copy link

E2E Test Results - Quickstart

11 passed

Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

@Isan-Rivkin Isan-Rivkin requested review from offirc2, kesarwam and a team November 21, 2024 13:48
Copy link
Contributor

@offirc2 offirc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

@Isan-Rivkin Isan-Rivkin merged commit 7f58e03 into master Nov 26, 2024
40 of 41 checks passed
@Isan-Rivkin Isan-Rivkin deleted the docs/ldap-additional-info branch November 26, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-changelog PR description should not be included in next release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs]: update LDAP enterprise docs to be helpful
2 participants